[flang][cuda] Relax host array check for cuda constant #120333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-semantics Author: Valentin Clement (バレンタイン クレメン) (clementval) ChangesArray with CONSTANT attribute declared in module spec part are device arrays and should not trigger the host array check. Full diff: https://github.com/llvm/llvm-project/pull/120333.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-cuda.cpp b/flang/lib/Semantics/check-cuda.cpp
index 15ee5f32f69b19..bec3969c7a26b7 100644
--- a/flang/lib/Semantics/check-cuda.cpp
+++ b/flang/lib/Semantics/check-cuda.cpp
@@ -114,6 +114,7 @@ struct FindHostArray
(!details->cudaDataAttr() ||
(details->cudaDataAttr() &&
*details->cudaDataAttr() != common::CUDADataAttr::Device &&
+ *details->cudaDataAttr() != common::CUDADataAttr::Constant &&
*details->cudaDataAttr() != common::CUDADataAttr::Managed &&
*details->cudaDataAttr() != common::CUDADataAttr::Shared &&
*details->cudaDataAttr() != common::CUDADataAttr::Unified))) {
diff --git a/flang/test/Semantics/cuf09.cuf b/flang/test/Semantics/cuf09.cuf
index 7452ee7cd7dc6a..b45ca6d7d1a9d7 100644
--- a/flang/test/Semantics/cuf09.cuf
+++ b/flang/test/Semantics/cuf09.cuf
@@ -1,6 +1,7 @@
! RUN: %python %S/test_errors.py %s %flang_fc1
module m
integer :: m(100)
+ integer, constant :: c(10)
integer, parameter :: p(5) = [1,2,3,4,5]
contains
attributes(device) subroutine devsub
@@ -42,6 +43,12 @@ module m
i = threadIdx%x
a(i) = s(10) ! ok, a is device and s is shared
end subroutine
+
+ attributes(global) subroutine cstarray(a)
+ integer, device :: a(10)
+ i = threadIdx%x
+ a(i) = c(10) ! ok, a is device and c is constant
+ end subroutine
end
program main
|
klausler
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array with CONSTANT attribute declared in module spec part are device arrays and should not trigger the host array check.